test/vite/baseurl-dotted-param.test.ts (1)

15-29: Consider restoring the original working directory in afterAll.

process.chdir(rootDir) modifies global process state. While the test is marked sequential, restoring the cwd in the teardown would improve isolation and prevent potential side effects on subsequent test files.

♻️ Suggested improvement

+  let originalCwd: string;
+
   beforeAll(async () => {
+    originalCwd = process.cwd();
     process.chdir(rootDir);
     server = await createServer({ root: rootDir });
     await server.listen("0" as unknown as number);
     const addr = server.httpServer?.address() as {
       port: number;
       address: string;
       family: string;
     };
     serverURL = `http://${addr.family === "IPv6" ? `[${addr.address}]` : addr.address}:${addr.port}`;
   }, 30_000);

   afterAll(async () => {
     await server?.close();
+    if (originalCwd) {
+      process.chdir(originalCwd);
+    }
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/vite/baseurl-dotted-param.test.ts` around lines 15 - 29, The test
changes the process cwd in beforeAll via process.chdir(rootDir) but never
restores it; capture the original working directory (e.g., const originalCwd =
process.cwd()) before calling process.chdir in the beforeAll block and then
restore it in afterAll (call process.chdir(originalCwd)) alongside closing the
server in the existing afterAll to avoid leaking global state; update the
beforeAll/afterAll in this test file (the hooks named beforeAll and afterAll in
test/vite/baseurl-dotted-param.test.ts) accordingly.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes